-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dispatch event on preview request #2076
Conversation
@rullzer, thanks for your PR! By analyzing the history of the files in this pull request, we identified @nickvergessen, @LukasReschke and @icewind1991 to be potential reviewers. |
@@ -43,6 +43,8 @@ | |||
*/ | |||
interface IPreview { | |||
|
|||
const EVENT = self::class . ':' . 'PREVIEWREQUESTED'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
stop shouting, use CamelCase?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also add a @since
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Fixes: #73 Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
e50ef56
to
99ada40
Compare
Current coverage is 57.73% (diff: 61.11%)@@ master #2076 diff @@
==========================================
Files 1156 1156
Lines 69608 69622 +14
Methods 7018 7018
Messages 0 0
Branches 1200 1200
==========================================
+ Hits 40190 40199 +9
- Misses 29418 29423 +5
Partials 0 0
|
👍 |
@nickvergessen @icewind1991 Please review ;) |
Looks good 👍 |
Fixes: #73
@LukasReschke as discussed.